Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tangle-shared-ui): Fix Incorrect Instance Provider #2859

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

AtelyPham
Copy link
Member

@AtelyPham AtelyPham commented Feb 28, 2025

Summary of changes

Provide a detailed description of proposed changes.

  • Remove redundant useSubstrateInjectedExtension hook from Tangle dApp.
  • Correct the provider instance.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

  • Closes NaN

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 242869b
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67c1fcead44987000871a9f8
😎 Deploy Preview https://deploy-preview-2859--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 242869b
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67c1fcea7edd2600083da139
😎 Deploy Preview https://deploy-preview-2859--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@drewstone
Copy link
Contributor

CI

@AtelyPham AtelyPham changed the title Fix(tangle-shared-ui): Fix Incorrect Instance Provider fix(tangle-shared-ui): Fix Incorrect Instance Provider Feb 28, 2025
@AtelyPham AtelyPham merged commit 8d5ded0 into develop Feb 28, 2025
16 of 17 checks passed
@AtelyPham AtelyPham deleted the trung-tin/fix-incorrect-instance-of-provider branch February 28, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

3 participants