Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tangle-dapp): Fix Restake Data not Showing #2876

Merged
merged 15 commits into from
Mar 7, 2025

Conversation

AtelyPham
Copy link
Member

@AtelyPham AtelyPham commented Mar 5, 2025

Summary of changes

Provide a detailed description of proposed changes.

  • Added loading property to data hook for data readiness indication.
  • Fixed deposit button functionality in the vault table.
  • Updated useEvmCallPermitNonce hook to use wagmi's useReadContract to address a bug in useContractRead returning null.
  • Handled null value for the TX relayer.
  • Added border to the vaults table.
  • Renamed vaults column to assets in the operators table.
  • Made the list modal scrollable.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

  • Closes NaN

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

CleanShot.2025-03-07.at.06.18.52.mp4

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 9fbd888
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67ca2daef9698d0008b87abd
😎 Deploy Preview https://deploy-preview-2876--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 9fbd888
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67ca2dae7822b90008ba4440
😎 Deploy Preview https://deploy-preview-2876--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AtelyPham AtelyPham marked this pull request as ready for review March 6, 2025 23:20
@yurixander
Copy link
Member

Code looks good

@devpavan04
Copy link
Member

@AtelyPham does this PR intend to fix the relayer transaction issue we encountered today, or will it be handled separately? Otherwise, looks good! 👍

CleanShot.2025-03-06.at.16.54.00.mp4

@drewstone
Copy link
Contributor

Please create a separate issue @devpavan04

@drewstone drewstone merged commit 6fefc98 into develop Mar 7, 2025
16 checks passed
@drewstone drewstone deleted the trung-tin/fix-restake-data-not-showing branch March 7, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

4 participants