Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add on_before_request to tauri-plugin-updater #2430

Merged
merged 9 commits into from
Mar 9, 2025

Conversation

goenning
Copy link
Contributor

This hook gives us much more flexibility when creating the Client for the HTTP request.

As an example, I personally need to do this:

.on_before_request(|b| b.use_preconfigured_tls(ClientConfig::with_platform_verifier()))

@goenning goenning requested a review from a team as a code owner February 16, 2025 15:14
Copy link
Contributor

github-actions bot commented Feb 16, 2025

Package Changes Through c2826b8

There are 6 changes which include clipboard-manager with patch, clipboard-manager-js with patch, log with minor, log-js with minor, updater with minor, updater-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.19 2.0.20
api-example-js 2.0.15 2.0.16
clipboard-manager 2.2.1 2.2.2
clipboard-manager-js 2.2.1 2.2.2
log 2.2.3 2.3.0
log-js 2.2.3 2.3.0
updater 2.5.1 2.6.0
updater-js 2.5.1 2.6.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

Can we add a comment in the same spirit as this one? https://docs.rs/tauri/latest/tauri/webview/struct.WebviewWindow.html#method.with_webview

Note that webview2-com, webkit2gtk, objc2_web_kit and similar crates may be updated in minor releases of Tauri. Therefore it’s recommended to pin Tauri to at least a minor version when you’re using with_webview.

I don't want us to be stuck with 0.11

@goenning goenning force-pushed the on_before_request branch 2 times, most recently from a1f4841 to 9b6acc2 Compare February 17, 2025 10:57
Signed-off-by: goenning <[email protected]>
@goenning
Copy link
Contributor Author

@FabianLars can you have a look now? I had to do some force-push juggling due to missing signed commits, but it should be ok now

@Dmitry-Titov-K
Copy link

FabianLars check pls

@FabianLars
Copy link
Member

You forgot the @ in front of my name. That's needed to actually ping me (assuming that's what you wanted to do judging by the link), without it it's just a normal message.

@goenning
Copy link
Contributor Author

goenning commented Mar 4, 2025

It seems to have worked regardless 😅

@FabianLars any thoughts on the PR as is it? Am I missing something?

@FabianLars
Copy link
Member

It seems to have worked regardless 😅

I read every message, just don't tell anyone that i'm actually just ignoring everything and everyone 🙃

PR looks good i think and i meant to merge it already but ended up forgetting about it. Will take another look at merging it tomorrow (i don't trust the mobile preview so can't do it now)

@goenning
Copy link
Contributor Author

goenning commented Mar 5, 2025

Renamed to configure_client + added to download.

@amrbashir
Copy link
Member

Should we include the same method on the plugin Builder as well?

@amrbashir amrbashir merged commit faefcc9 into tauri-apps:v2 Mar 9, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants