Editorial: Fix spec link for and remove unused parameter from new ValidateDurationUnitStyle AO #969
Conversation
trflynn89
changed the title
| @@ -648,10 +648,9 @@ <h1> | |||
| }. | |||
| </emu-alg> | |||
|
|
|||
| <emu-clause id="sec-stringpaddingbuiltinsimpl" type="abstract operation"> | |||
| <emu-clause id="sec-validatedurationunitstyle" type="abstract operation"> | |||
There was a problem hiding this comment.
Thanks @trflynn89; I've merged this fix as #970.
| <h1> | ||
| ValidateDurationUnitStyle ( | ||
| _unit_: a String, |
There was a problem hiding this comment.
Inclusion of a seemingly-irrelevant unit parameter was intentional; I expect its contents to appear in the message of any thrown exception just as it would have before being factored out of GetDurationUnitOptions in 20daf26. But this is obviously too subtle... perhaps, rather than dropping the parameter, we should have a note explaining how it might be used?
There was a problem hiding this comment.
Ah gotcha, yeah a note here would be helpful for clarity. In Ladybird's implementation of these changes, I've actually included a couple of extra parameters to this AO to create useful exception messages, so I'm not sure that unit being treated specially by the spec is all that necessary for implementers.
There was a problem hiding this comment.
Thanks! I'll go ahead and close this PR
No description provided.