Console Runner: Fix Race Condition #514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When spawning threads from within a `for` loop, the original parallelization implementation relied on a function closure to access each `TestCase` instance. Due to the concurrent and non-deterministic nature of thread processing, the value of this reference at execution time was unstable. Explicitly specify the `TestCase` instance to the `Thread` constructor, ensuring that each thread is run with the intended value, regardless of execution order.
|
Closing in favor of #513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spawning threads from within a
forloop, the originalparallelization implementation relied on a function closure to access
each
TestCaseinstance. Due to the concurrent and non-deterministicnature of thread processing, the value of this reference at execution
time was unstable.
Explicitly specify the
TestCaseinstance to theThreadconstructor,ensuring that each thread is run with the intended value, regardless of
execution order.
Resolves gh-512.