[runner] Add support for "folding" block delimiter #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can merge this as a final last to the test runner. While it's still here, let it be fixed. |
IgnoredAmbience
added a commit
to resource-reasoning/runtests
that referenced
this pull request
Jun 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently began using the
|character as a delimiter for YAML blocks in test files. The content of these blocks can confuse the custom YAML parser, disrupting test runs.It looks like TC-39 has reached consensus on gh-647 ("Definitive decision for Test262 console runner"), but I'm not sure what that decision was.
In any case, the code is still in use, and this is a blocking bug (no pun intended--honest). The fix was simple enough; we can either merge it to
masterhere, or allow consumers to apply the patch to their forks of the runner.