-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PipelineResource support #734
Comments
Heads up - Pipelines was still allowing creation of PipelineResources via v1beta1 through v0.45.0, so it's very likely that there's still usage of Pipeline Resources for recent clients. Support was removed in v0.46.0, but the API types were removed as well so this breaks our ability to safely watch older Tekton versions if we update our client version to v0.46.0 😭 I reached out on the Pipelines PR to ask to roll back the client changes. |
After creating #764 to remove it, I just realized this ticket. Thanks for creating this ticket. Should we remove support for the pipelineresources in Chains? I feel like if we don't remove it, users who use the combo of pipeline >= v0.46 and chains >= 0.16 will have trouble. |
fixes tektoncd#734 - bump github.com/tektoncd/pipeline to v0.46.0 - bump k8s.io/client-go to v0.25.7 - bump k8s.io/code-generator to v0.25.7 - bump knative.dev/pkg to v0.0.0-20230221145627-8efb3485adcf - remove support for PipelineResources in Chains. Signed-off-by: Chuang Wang <[email protected]>
Good question. According to this, the pipeline release v0.44.0 is still supported until Jan 24, 2024. So maybe we should until then? |
I'd like to keep compatibility with current supported pipeline LTS versions, unless there's a good reason we can't. We got the resources API change reverted in tektoncd/pipeline#6436 - if/when pipeline releases v0.46.1 we should be able to upgrade with compatibility. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PipelineResources have been deprecated from Pipelines for quite some time now (https://github.com/tektoncd/pipeline/blob/main/docs/deprecations.md#deprecation-table says since Dec 2021) - we should be safe to rip this out from Chains.
The text was updated successfully, but these errors were encountered: