Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP0074 Update plans to remove pipelineResources #922

Merged
merged 1 commit into from
Jan 23, 2023
Merged

TEP0074 Update plans to remove pipelineResources #922

merged 1 commit into from
Jan 23, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jan 10, 2023 •
edited
Loading

This commit updates the TEP‘s proposal to remove pipelineResources before swapping the storage version to v1.
It conforms to the deprecations.md and api_compatibility_policy.md.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2023
@JeromeJu JeromeJu mentioned this pull request Jan 10, 2023
Closed
12 tasks
lbernick
lbernick reviewed Jan 11, 2023
View reviewed changes
@JeromeJu JeromeJu force-pushed the tep74-update-resources-deprecation branch from a153a25 to af03fb9 Compare January 12, 2023 18:59
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2023
@JeromeJu JeromeJu force-pushed the tep74-update-resources-deprecation branch from af03fb9 to cd311fe Compare January 12, 2023 19:01
@JeromeJu JeromeJu requested review from lbernick and removed request for vdemeester and khrm January 12, 2023 19:03
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@lbernick
Copy link
Member

@pritidesai @vdemeester are either of you able to take a look at this small PR? (Just tagging you due to comments on tektoncd/pipeline#5967)

@jerop
Copy link
Member

jerop commented Jan 23, 2023

/kind tep

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Jan 23, 2023
@afrittoli
Copy link
Member

/test pull-community-teps-lint

@tekton-robot
Copy link
Contributor

@afrittoli: No presubmit jobs available for tektoncd/community@main

In response to this:

/test pull-community-teps-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

Approved during API WG
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2023
@tekton-robot tekton-robot merged commit d9b6038 into tektoncd:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

Assignees

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeromeJu @tekton-robot @lbernick @jerop @afrittoli