Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI enchancement] Refactor directory structure for the enhanced CLI #980

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Mar 7, 2025

Changes

These changes are related to TEP-0160
Modified the directory structure so that code for the enhanced CLI can be properly placed without changing the existing functionalities.
Once the enhanced CLI is ready to use, we should add a deprecated message to the existing commands and advise users to use the new commands. As of now, there is no plan to remove these commands as those can be handy for debugging purposes.

/kind misc
/release-note-none

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2025
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign avinal after the PR has been reviewed.
You can assign the PR to them by writing /assign @avinal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from dibyom and khrm March 7, 2025 12:40
@divyansh42
Copy link
Member Author

/cc @khrm @vdemeester

@tekton-robot tekton-robot requested a review from vdemeester March 7, 2025 12:41
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cli/dev/client/client.go Do not exist 15.0%
pkg/cli/dev/cmd/list.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/get.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/list.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/logs.go Do not exist 0.0%
pkg/cli/dev/cmd/records/get.go Do not exist 0.0%
pkg/cli/dev/cmd/records/list.go Do not exist 0.0%
pkg/cli/dev/cmd/records/records.go Do not exist 0.0%
pkg/cli/dev/config/config.go Do not exist 48.3%
pkg/cli/dev/flags/flags.go Do not exist 0.0%
pkg/cli/dev/format/format.go Do not exist 0.0%
pkg/cli/dev/portforward/portforward.go Do not exist 0.0%

@divyansh42
Copy link
Member Author

/test pull-tekton-results-unit-tests

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cli/dev/client/client.go Do not exist 15.0%
pkg/cli/dev/cmd/list.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/get.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/list.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/logs.go Do not exist 0.0%
pkg/cli/dev/cmd/records/get.go Do not exist 0.0%
pkg/cli/dev/cmd/records/list.go Do not exist 0.0%
pkg/cli/dev/cmd/records/records.go Do not exist 0.0%
pkg/cli/dev/config/config.go Do not exist 48.3%
pkg/cli/dev/flags/flags.go Do not exist 0.0%
pkg/cli/dev/format/format.go Do not exist 0.0%
pkg/cli/dev/portforward/portforward.go Do not exist 0.0%

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cli/dev/client/client.go Do not exist 15.0%
pkg/cli/dev/cmd/list.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/get.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/list.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/logs.go Do not exist 0.0%
pkg/cli/dev/cmd/records/get.go Do not exist 0.0%
pkg/cli/dev/cmd/records/list.go Do not exist 0.0%
pkg/cli/dev/cmd/records/records.go Do not exist 0.0%
pkg/cli/dev/config/config.go Do not exist 48.3%
pkg/cli/dev/flags/flags.go Do not exist 0.0%
pkg/cli/dev/format/format.go Do not exist 0.0%
pkg/cli/dev/portforward/portforward.go Do not exist 0.0%

@divyansh42 divyansh42 changed the title [WIP] CLI enchancement: Refactor directory structure for the enhanced CLI [CLI enchancement] Refactor directory structure for the enhanced CLI Mar 7, 2025
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants