Add skip_download parameter to get. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsdalmo
changed the title
| @@ -11,6 +11,16 @@ import ( | |||
|
|
|||
| // Get (business logic) | |||
| func Get(request GetRequest, github Github, git Git, outputDir string) (*GetResponse, error) { | |||
| if request.Params.SkipDownload != "" { | |||
There was a problem hiding this comment.
Shouldn't we check if this is true?
There was a problem hiding this comment.
Afaik, Concourse passes booleans in as strings so it's up to us to parse it into a boolean, and few lines further down we check whether it parses to true. Or did I misunderstand you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #32