Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make disable_ci_skip a boolean instead of string #38

Merged
merged 3 commits into from
Sep 24, 2018

Conversation

itsdalmo
Copy link
Contributor

Ref #37 - for consistency we should use true boolean values wherever possible. I'm not sure why I opted for boolean parseable string to begin with 🤷‍♂️

Copy link

@mikael-lindstrom mikael-lindstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@itsdalmo itsdalmo merged commit 54b8c9a into master Sep 24, 2018
@itsdalmo itsdalmo deleted the make-disable-ci-skip-boolean branch September 24, 2018 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants