Rust / Packages upgrade #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
rust-upgrade
branch
from
4317298 to
1e3261c
Compare
|
Dropped the otel upgrades and left them in https://github.com/temporalio/sdk-core/tree/otel-upgrade |
cretz
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Upgrade rust, and crates,
and Otel (maybe)Problem is Otel has managed to break something. In this case, error logging (they also are logging some uninteresting junk at INFO level). AFAICT errors simply aren't logged while trying to export metrics. This happens in a new thread now and after wasting a bunch of time on this I gave up trying to figure out exactly why. I opened an issue for them.
We can simply not upgrade otel for now, but we'll be stuck on that git revision of the prom exporter.
Why?
Updates good.
Checklist
Closes [Feature Request] Fix recent clippy warnings #879
How was this tested:
Existing tests
Any docs updates needed?