Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Confirm absense of metric config still results in no-op metric meter #135

Closed
cretz opened this issue Sep 8, 2023 · 0 comments · Fixed by #202
Closed

[Feature Request] Confirm absense of metric config still results in no-op metric meter #135

cretz opened this issue Sep 8, 2023 · 0 comments · Fixed by #202
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Sep 8, 2023

Describe the solution you'd like

When developing this feature in Python, it appeared that the metric meter was not created when metrics config is not present. So we need to use a no-op one
@cretz cretz added the enhancement New feature or request label Sep 8, 2023
cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue Mar 7, 2024
@cretz
Fix issue with unconfigured metric meter
defe094 
Fixes temporalio#135
@cretz cretz mentioned this issue Mar 7, 2024
Merged
@cretz cretz closed this as completed in #202 Mar 7, 2024
cretz added a commit that referenced this issue Mar 7, 2024
@cretz
Fix issue with unconfigured metric meter (#202)
666ab45 
Fixes #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with unconfigured metric meter cretz/temporal-sdk-dotnet
1 participant
@cretz