Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Not ignoring unknown fields when parsing history for replay #173

Closed
cretz opened this issue Jan 9, 2024 · 0 comments · Fixed by #175
Closed

[Bug] Not ignoring unknown fields when parsing history for replay #173

cretz opened this issue Jan 9, 2024 · 0 comments · Fixed by #175
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Jan 9, 2024

Describe the bug

Python and Go and others ignore unknown fields when parsing JSON for history proto, but .NET doesn't. Even though docs don't show it, there is an ignore-unknown-fields setting on JsonParser settings.
@cretz cretz added the bug Something isn't working label Jan 9, 2024
cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue Jan 10, 2024
@cretz
Properly ignore unknown fields when parsing history JSON
c6cc814 
Fixes temporalio#173
@cretz cretz mentioned this issue Jan 10, 2024
Merged
cretz added a commit that referenced this issue Jan 10, 2024
@cretz
Properly ignore unknown fields when parsing history JSON (#175)
53a8a3d 
Fixes #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly ignore unknown fields when parsing history JSON cretz/temporal-sdk-dotnet
1 participant
@cretz