Add build id to workflow context #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jan 10, 2024
| /// be used. This value may change over the lifetime of the workflow run, but is | ||
| /// deterministic and safe to use for branching. | ||
| /// </remarks> | ||
| public static string CurrentBuildId => Context.CurrentBuildId; |
There was a problem hiding this comment.
Thank you for 1) not actually putting this on workflow info, and 2) respecting alphabetical order
src/Temporalio/Bridge/sdk-core
Outdated
There was a problem hiding this comment.
You'll have to regen protos with the updated core (see https://github.com/temporalio/sdk-dotnet/#regenerating-protos, make sure it's 3.x protoc on the PATH). We have a CI check that makes sure our generated protos are up to date with the upstream API as seen in the core submodule and it looks like there have been additions.
Sushisource
force-pushed
the
build-id-workflow-info
branch
from
fd01c91 to
74deb38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Part of temporalio/features#253
Checklist
Closes
How was this tested:
Added IT
Any docs updates needed?