Support for workflow ID conflict policy #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
force-pushed
the
workflow-id-conflict-policy
branch
from
c9c5f7c to
f2b93ce
Compare
cretz
force-pushed
the
workflow-id-conflict-policy
branch
from
f2b93ce to
42e1141
Compare
Sushisource
approved these changes
Jul 12, 2024
Comment on lines
+67
to
+68
| /// <see cref="WorkflowIdConflictPolicy.Unspecified" /> which effectively means | ||
| /// <see cref="WorkflowIdConflictPolicy.Fail"/> on the server. If this value is set, then |
There was a problem hiding this comment.
Same comment as Python. Maybe we just want to default to FAIL explicitly?
There was a problem hiding this comment.
👍 Discussed at temporalio/sdk-python#579 (comment) (basically it's unfortunate but required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
WorkflowOptions.IdConflictPolicyand testChecklist