Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing workflow #260

Merged
merged 20 commits into from
Oct 21, 2024
Merged

Conversation

aktech
Copy link
Member

@aktech aktech commented Oct 2, 2024

This PR adds testing workflow.

TODO:

  • Extract a common reusable steps into separate action
  • Separate out test and build workflows
  • xfail all the failing tests
  • Remove temporary/misc changes to workflows, which are done only for testing purposes.

XFAIL tests can be addressed in a follow PR, based on the priority.

A lot of XFAILs can be fixed easily by porting from absl.testing.parameterized to pytest.mark.parametrize, but that's for another PR.

Looks like the @tfx-copybara bot deleted my changes from #259 again: 052aec8 (This PR also adds it back)

@aktech aktech marked this pull request as ready for review October 4, 2024 11:21
Copy link

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes requested, otherwise looks good!

@aktech aktech force-pushed the testing-workflow branch 2 times, most recently from e83cbfd to 99f83b7 Compare October 7, 2024 08:29
@rtg0795 rtg0795 requested a review from caveness October 7, 2024 17:55
@peytondmurray peytondmurray self-requested a review October 16, 2024 20:18
@peytondmurray peytondmurray merged commit d3710e6 into tensorflow:master Oct 21, 2024
8 checks passed
@peytondmurray
Copy link

@caveness As a follow up, we need to ensure that copybara is not overwriting github contributions - is there anything I can do to help with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants