-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing workflow #260
Merged
Merged
Add testing workflow #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5e706d
to
57c1e5b
Compare
peytondmurray
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes requested, otherwise looks good!
smokestacklightnin
approved these changes
Oct 4, 2024
e83cbfd
to
99f83b7
Compare
99f83b7
to
ec0e02a
Compare
peytondmurray
approved these changes
Oct 16, 2024
@caveness As a follow up, we need to ensure that copybara is not overwriting github contributions - is there anything I can do to help with that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testing workflow.
TODO:
XFAIL tests can be addressed in a follow PR, based on the priority.
A lot of XFAILs can be fixed easily by porting from
absl.testing.parameterized
topytest.mark.parametrize
, but that's for another PR.Looks like the @tfx-copybara bot deleted my changes from #259 again: 052aec8 (This PR also adds it back)