Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(x11/thunderbird): 128.8.0 #23616

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

TomJo2000
Copy link
Member

closes #23615

Trying to figure out what actually failed.
Did a test build of aarch64 locally and it worked.

@TomJo2000 TomJo2000 requested a review from Grimler91 as a code owner March 6, 2025 03:26
@licy183
Copy link
Member

licy183 commented Mar 6, 2025

Trying to figure out what actually failed. Did a test build of aarch64 locally and it worked.

Possible due to out of disk space.

@TomJo2000
Copy link
Member Author

Unfortunately the build log in the auto update workflow is too long by the time it gets to thunderbird so I don't have any way to confirm that.

@twaik
Copy link
Member

twaik commented Mar 6, 2025

Probably we should make cleanup threshold bigger. Or make it force cleanup without checking for disk space, anyways CI does not reuse build folders.

@TomJo2000
Copy link
Member Author

Probably we should make cleanup threshold bigger. Or make it force cleanup without checking for disk space, anyways CI does not reuse build folders.

I don't think it's an issue of the threshold itself.
That is mostly guesswork.
But shouldn't it also automatically do a cleaning run before build a big package?


local big_package=false
while IFS= read -r p; do
if [[ "${p}" == "${TERMUX_PKG_NAME}" ]]; then
big_package=true
break
fi
done < "${TERMUX_SCRIPTDIR}/scripts/big-pkgs.list"
if [[ "${big_package}" == "true" ]]; then
"${TERMUX_SCRIPTDIR}/scripts/run-docker.sh" ./clean.sh
fi
if ! "${TERMUX_SCRIPTDIR}/scripts/run-docker.sh" ./build-package.sh -C -a "${TERMUX_ARCH}" -i "${TERMUX_PKG_NAME}"; then
if [[ "${big_package}" == "true" ]]; then
"${TERMUX_SCRIPTDIR}/scripts/run-docker.sh" ./clean.sh
fi
git checkout -- "${TERMUX_PKG_BUILDER_DIR}"
termux_error_exit "ERROR: failed to build."
fi
if [[ "${big_package}" == "true" ]] || [[ "${force_cleanup}" == "true" ]]; then
"${TERMUX_SCRIPTDIR}/scripts/run-docker.sh" ./clean.sh
fi

I'm not sure that that is working as intended.
I'll check if I can pull the raw logs from the CI run.

@TomJo2000
Copy link
Member Author

Trying to figure out what actually failed. Did a test build of aarch64 locally and it worked.

Possible due to out of disk space.

Call it a hunch.
I think you were completely right about that.

image

@twaik
Copy link
Member

twaik commented Mar 6, 2025

Wait a sec. For some reason I put the check in the wrong place. Weird thing. I'll move it.

@TomJo2000
Copy link
Member Author

Wait a sec. For some reason I put the check in the wrong place. Weird thing. I'll move it.

Open a PR, I have some other ideas.
Like adding a print out to clean.sh stating that it is being run, and conditionally what triggered it (e.g. big packages/cleanup flag)

@TomJo2000 TomJo2000 merged commit e0f6b3f into termux:master Mar 6, 2025
9 checks passed
@TomJo2000 TomJo2000 deleted the thunderbird-128.8 branch March 6, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto update failing for thunderbird
3 participants