Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible breaking change on recent version released #252

Closed
andresg747 opened this issue Feb 2, 2019 · 8 comments
Closed

Possible breaking change on recent version released #252

andresg747 opened this issue Feb 2, 2019 · 8 comments

Comments

@andresg747
Copy link

andresg747 commented Feb 2, 2019 •
edited
Loading

Bug report

I'm getting TypeError: Cannot read property 'minify' of undefined errors on build.

Details on vercel/next.js#6194

Is it possible that the most recent version of terser released 2 hours ago is related to that issue?

Thanks in advance!

UPDATE

The fix is being addressed here.
Meanwhile, if you cannot wait for an official release with the patch, there is a suggested workaround:
vuejs/vue-cli#3407 (comment)
@haoqunjiang
Copy link

See #251

@hamitzor
Copy link

hamitzor commented Feb 2, 2019

Yes, I was playing with some of the configuration and I thought I messed them up, trying to solve this problem about 5 hours. I just figured out it was related to a new update.

@mrmckeb
Copy link

mrmckeb commented Feb 3, 2019

This is also affecting Create React App. See facebook/create-react-app#6334.

@TrySound
Copy link
Contributor

TrySound commented Feb 3, 2019

@mrmckeb It's terser-webpack-plugin problem. They imported default with interop from the package with potential named exports.

@mrmckeb
Copy link

mrmckeb commented Feb 3, 2019

Thanks @TrySound, I'll chase them up.

@ulivz ulivz mentioned this issue Feb 3, 2019
Closed
1 task
@BuddhiAbeyratne
Copy link

FYI Issue also effects Nuxt
nuxt/nuxt#4931

byCedric added a commit to byCedric/GitHub-Website-legacy that referenced this issue Feb 4, 2019
@byCedric
fix: manually rollback to terser 3.14.1
89d9be8 
See terser/terser#252
byCedric added a commit to byCedric/GitHub-Website-legacy that referenced this issue Feb 4, 2019
@byCedric
chore: rebuild lock file from scratch (#92)
ab66d29 
* chore: rebuild lock file from scratch

This fixes issues related to missing nested dependencies in the convention packages.

* fix: include stylelint manually

This fixes a strange behaviour with the `@peakfijn/config-stylelint` package.

* fix: manually rollback to terser 3.14.1

See terser/terser#252

* test: use proper url in highlight test

This fixes some eslint warnings lecturing about accessible link elements.
@vladimiry
Copy link

Is not this duplicate of #251?

@mrmckeb It's terser-webpack-plugin problem. They imported default with interop from the package with potential named exports.

It would be terser-webpack-plugin's problem if that would be a v4 terser release, but it's v3.16.0. So it's terser's problem as the change is breaking.

This was referenced Feb 4, 2019
Merged
Merged
@fabiosantoscode
Copy link
Collaborator

Thanks for the report. Fixed in 3.16.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@vladimiry @fabiosantoscode @haoqunjiang @mrmckeb @TrySound @andresg747 @BuddhiAbeyratne @hamitzor