Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 22 is no longer available. Moving JDK23 #3214

Conversation

krmahadevan
Copy link
Member

@krmahadevan krmahadevan commented Mar 6, 2025

Summary by CodeRabbit

  • Chores
    • Updated our configuration to use the latest early access Java version, ensuring our build and testing workflows remain aligned with current compatibility standards.

@krmahadevan krmahadevan requested a review from juherr as a code owner March 6, 2025 04:21
Copy link

coderabbitai bot commented Mar 6, 2025

Walkthrough

The pull request updates the GitHub Actions matrix configuration by modifying the early access Java version constant. The constant eaJava is changed from '22' to '23', ensuring that the updated Java version is included in the java_version axis of the matrix configuration. No additional logic or control flow modifications are introduced.

Changes

File(s) Change Summary
.github/workflows/matrix.js Updated constant eaJava from '22' to '23' in the matrix setup

Poem

I hopped through code with a joyful beat,
Changing Java versions in my little suite.
From '22' to '23' I cheerfully roam,
Bringing a fresher version to our home.
With twitching whiskers and hops so neat!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a25754 and 5246047.

📒 Files selected for processing (1)
  • .github/workflows/matrix.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: 23, oracle, macos, Pacific/Chatham, tr_TR
  • GitHub Check: 21, corretto, windows, Pacific/Chatham, fr_FR
  • GitHub Check: 17, microsoft, ubuntu, Pacific/Chatham, fr_FR
  • GitHub Check: 17, microsoft, macos, Pacific/Chatham, de_DE, stress JIT
  • GitHub Check: 11, zulu, ubuntu, America/New_York, ru_RU
  • GitHub Check: 11, zulu, same hashcode, macos, Pacific/Chatham, fr_FR
  • GitHub Check: 11, microsoft, ubuntu, UTC, ru_RU, stress JIT
🔇 Additional comments (1)
.github/workflows/matrix.js (1)

23-23: Version update looks good.

Updating the early access Java version from 22 to 23 is appropriate since JDK 22 is no longer in early access mode. This ensures CI continues to test with the latest early access version.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@krmahadevan krmahadevan requested review from juherr and removed request for juherr March 6, 2025 04:29
@juherr
Copy link
Member

juherr commented Mar 6, 2025

Duplicated by #3215

@krmahadevan krmahadevan closed this Mar 6, 2025
@krmahadevan krmahadevan deleted the fix_jdk22_ea_oracle_reference branch March 6, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants