Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampersand in BIOS Settings #90

Closed
ryanwb3 opened this issue Apr 19, 2019 · 5 comments
Closed

Ampersand in BIOS Settings #90

ryanwb3 opened this issue Apr 19, 2019 · 5 comments

Comments

@ryanwb3
Copy link

ryanwb3 commented Apr 19, 2019

Trying to set BIOS setting:
Password prompt on F9 F11 & F12 == Enable

Looks like the ampersand is escaping in XML. Might need to add a check for & character in BIOS Settings and inster the correct value.

@ryanwb3
Copy link
Author

ryanwb3 commented Apr 19, 2019

It is the return message from the BCU it contains the & character and is breaking the reading of the BCU return information:
VERBOSE: === BCU Result =============================== VERBOSE: <BIOSCONFIG Version="" Computername="Removed" Date="2019/04/19" Time="14:42:57" UTC="-4"> <SUCCESS msg="Successfully read password from file" /> <SETTING changeStatus="skip" name="Password prompt on F9 F11 & F12" returnCode="18"> <OLDVALUE><![CDATA[Enable]]></OLDVALUE> <VALUE><![CDATA[Enable]]></VALUE> </SETTING> <SUCCESS msg="No errors occurred" /> <Information msg="BCU return value" real="0" translated="0" /> </BIOSCONFIG> VERBOSE: ============================================== PS>TerminatingError(): "Error trying to parse BCU output: Cannot convert value "<BIOSCONFIG Version="" Computername="Removed" Date="2019/04/19" Time="14:42:57" UTC="-4"> <SUCCESS msg="Successfully read password from file" /> <SETTING changeStatus="skip" name="Password prompt on F9 F11 & F12" returnCode="18"> <OLDVALUE><![CDATA[Enable]]></OLDVALUE> <VALUE><![CDATA[Enable]]></VALUE> </SETTING> <SUCCESS msg="No errors occurred" /> <Information msg="BCU return value" real="0" translated="0" /> </BIOSCONFIG> " to type "System.Xml.XmlDocument". Error: "An error occurred while parsing EntityName. Line 3, position 64.""

@texhex
Copy link
Owner

texhex commented Apr 24, 2019

Thanks for the report!

As you wrote, the error is clearly within the BCU tool, hence the best chance would be to open a case with HP so they can fix it. However, when checking which models support this setting, the only ones I found was ProDesk 600 G1, Z420 and a Z440. I have no idea if those devices are not already declared End-of-life by HP so they could simply deny the change in BCU.

The only idea I had to get this working would be to add a "hack" that checks the output from BCU and replaces

name="Password prompt on F9 F11 & F12"
with
name="Password prompt on F9 F11 and F12"

How urgent is that you get this supported, is this a critical road block for you?

@ryanwb3
Copy link
Author

ryanwb3 commented Apr 26, 2019

I just ran a -replace on the bcu results.

@texhex
Copy link
Owner

texhex commented May 2, 2019

Yes, at the end this will be likely the easiest method. I will implement this and include it with 6.0.

@texhex
Copy link
Owner

texhex commented May 5, 2019

Code is live, 6.0.1 BETA will be out in about 30 minutes, it would be great if you could test it if this fixed the bug for you. If not, please feel free to reopen this issue.

@texhex texhex closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants