Adds unzip module #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows downloading and extracting zips from urls
|
Proof in pudding |
Mothblocks
reviewed
Oct 24, 2020
Mothblocks
reviewed
Oct 24, 2020
| let reader = std::io::Cursor::new(content); | ||
| let mut archive = ZipArchive::new(reader)?; | ||
|
|
||
| for i in 0..archive.len() |
There was a problem hiding this comment.
i'm kinda dumbfounded that there's no Iterator for this. oh well
There was a problem hiding this comment.
Felt weird to me so I looked it up, https://users.rust-lang.org/t/is-it-possible-to-create-an-iterator-for-ziparchive-in-zip-crate/5744/3
tldr you can’t make an Iterator that takes a ZipArchive and yields ZipFile items. This is because a ZipFile mutably borrows the ZipArchive's reader, so a single archive can only have one ZipFile at a time.
Rohesie
reviewed
Oct 26, 2020
Co-authored-by: Rohesie <[email protected]>
spookydonut
approved these changes
Oct 27, 2020
Mothblocks
approved these changes
Oct 27, 2020
|
@tgstation/rust-g-dev-team meep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows downloading and extracting zips from urls
Closes #50
Needed for out of repo maps