Remove unordered list from Marquee & ensure we have no empty rows #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: caff0f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📚 Storybook DeploymentThe latest changes are available as preview in: https://b93a646a.the-guild-docs-storybook.pages.dev |
hasparus
commented
Feb 4, 2025
| @@ -106,11 +106,15 @@ export function MarqueeRows({ | |||
| className, | |||
| ...rest | |||
| }: MarqueeRowsProps) { | |||
| const chunkSize = Math.ceil(children.length / rows); | |||
| const chunkSize = Math.floor(children.length / rows); | |||
There was a problem hiding this comment.
I ended up with an empty chunk bcs of
48 / 9 == 5.3333
ceil(5.333) == 6
now the math is correct
saihaj
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon using it a bit, I realized that
<ul>was added mistakenly, and I copy-pasted it like a dumbo.Also fixed the math for chunking so we don't add an empty row.