Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复了一些bug, 增加了log信息 #1806

Merged
merged 5 commits into from
May 7, 2021
Merged

修复了一些bug, 增加了log信息 #1806

merged 5 commits into from
May 7, 2021

Conversation

FoundTheWOUT
Copy link
Contributor

之前一直没开画中画...发现画中画会导致自动暂停出现一些bug
顺便添加了一些首页过滤

@FoundTheWOUT
Copy link
Contributor Author

@the1812 先不要merge这个PR, 我发现在番剧页面没有player-wrap这个东西...我真的🙃

@the1812
Copy link
Owner

the1812 commented May 2, 2021

去监测 .bilibili-player 吧, 它上面的 class 是可以判断出当前的播放器模式的

@FoundTheWOUT
Copy link
Contributor Author

FoundTheWOUT commented May 2, 2021 •
edited
Loading

去监测 .bilibili-player 吧, 它上面的 class 是可以判断出当前的播放器模式的

不行啊, 拿.bilibili-player能知道播放模式, 但是计算不出位置
好像是可以的, 就是有点麻烦

@the1812
Copy link
Owner

the1812 commented May 2, 2021

啊..为啥算不出位置

@FoundTheWOUT
Copy link
Contributor Author

我看了下player-wrap和player-module, 这两个类估计是能覆盖大部分情况了.
以后遇到情况以后再算吧

@FoundTheWOUT
Copy link
Contributor Author

@the1812 差不多了， 随时可以merge

@the1812
Copy link
Owner

the1812 commented May 6, 2021

好的 (换 IntersectionObserver 好评

@the1812 the1812 merged commit a838a0e into the1812:preview May 7, 2021
the1812 added a commit that referenced this pull request May 8, 2021
@the1812
Build PR #1806
55f5a6b
@Kingcrypto38 Kingcrypto38 mentioned this pull request Jan 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FoundTheWOUT @the1812