Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #140 - Resolve gpus TypeError #141

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Aug 22, 2016

Resolves #140 - gpus TypeError

@solarkennedy
Copy link
Contributor

Ty for the PR. It just feel kinda yucky that it breaks on an unreleased, undocumented thing :(

Granted, this would have been caught when we upgrade the travis matrix to include marathon 1.3 when it comes out!

@solarkennedy solarkennedy merged commit 7cd825a into thefactory:master Aug 22, 2016
@mbeacom mbeacom deleted the fix-140-gpus branch August 22, 2016 19:37
@mbeacom mbeacom restored the fix-140-gpus branch August 22, 2016 19:37
@mbeacom
Copy link
Contributor Author

mbeacom commented Aug 22, 2016

@solarkennedy Thank you for merging this ahead of the release! We recently upgraded to the DC/OS 1.8 release and we ran into the error in the client. Figured I would submit the PR!

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants