[fix] Handle non-JSON errors from Marathon #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hlerebours
commented
Mar 17, 2017
hlerebours
commented
- it answers to ValueError when 401 Unauthorized is received #22
- it proposes a different implementation (without catching exceptions) than:
- 9443c7d
- 7f2999f
- it adds two tests to verify the behavior of the new condition
|
Thanks! |
mattmb
added a commit
to Yelp/paasta
that referenced
this pull request
Mar 28, 2017
Some tests were broken by thefactory/marathon-python#178 This makes them pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.