Local tests no longer need docker-compose and rely on "mini-marathon" #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,11 +1,12 @@ | |||
| ARG MARATHONVERSION=v1.6.322 | |||
There was a problem hiding this comment.
do we still need this?
There was a problem hiding this comment.
Yes, we still need it because of this https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact
| @@ -1,11 +1,12 @@ | |||
| ARG MARATHONVERSION=v1.6.322 | |||
| FROM mesosphere/marathon:$MARATHONVERSION | |||
There was a problem hiding this comment.
too bad we cant just use the upstream image directly?
There was a problem hiding this comment.
I tried using it directly but your functional tests go deeper and we need mesos-master and mesos-agent for all tests to work.
BTW, having these tests is great, I would go as far as to say these are end-to-end <3
| [[ -n $TRAVIS ]] || docker-compose build --build-arg "MARATHONVERSION=${MARATHONVERSION}" | ||
| [[ -n $TRAVIS ]] || docker-compose pull | ||
| [[ -n $TRAVIS ]] || docker-compose up -d | ||
| [[ -n $TRAVIS ]] || docker pull "missingcharacter/marathon-python:${MARATHONVERSION}" |
There was a problem hiding this comment.
This is a good optimization. Your docker hub account is as good as any.
|
Thanks for getting rid of compose. KISS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works here: https://travis-ci.org/github/missingcharacter/marathon-python/builds/690125304