Remove call to logging.basicConfig #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's rude to interfere with the using application logging configuration...
|
Ah! Thanks! I agree a library should not do this. |
solarkennedy
added a commit
that referenced
this pull request
Oct 28, 2015
Remove call to logging.basicConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's rude to interfere with the using application logging configuration...
See this about "explicitly configuring handlers", which is what
basicConfigdoes.The effect in my application is that it adds a handler to my already existing handlers, causing duplicate output to the console in a way I cannot control.