[DEP0005] Replace fd-slicer dependency with fd-slicer2 fork #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore: replace fd-slicer by fd-slicer2 fork. BC: remove compatibility with Node <6 and adds Node 12/13 to CI test suite.
|
@nalhabash thanks for fix |
2 tasks
|
Please merge these fixes. |
|
Hi, is there any update on this one please? |
fengmk2
added a commit
to node-modules/yauzl
that referenced
this pull request
Feb 24, 2023
fengmk2
added a commit
to node-modules/yauzl
that referenced
this pull request
Feb 24, 2023
|
Hi there! Any update? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In another project i was working on I had this error show up:
After some digging i figured out that it was because of the fd-slicer dependency that yauzl was using, and it seemed the repo owner isn't maintaining it anymore. (see that one closed PR: andrewrk/node-fd-slicer#4)
These changes in the fork break compatibility with versions up to 4 of Node.