Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

851 Backup Without Snapshot Creation & Deletion #852

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PACordonnier
Copy link

Fixes #851

Hi,

Added two flags to the "backup" command. The default behaviour of backup is unchanged : it creates a snapshot and deletes it on successful backup.

New flags:

--keep-snapshot: dont delete snapshot on successful backup.
--use-existing-snapshot: dont create a snapshot, use a previously existing one.

  • Raises an error when --use-existing-snapshot is set and --backup-name is not defined.
  • Raises an error when --use-existing-snapshot and snapshot cant be found.

If the feature is accepted in principle, I’m happy to explore ways to add tests. Currently the integration_steps does not manage nodetool operations needed for theses features (such as snapshot and listsnapshots).

Also I can work on adding feature to the backup-cluster. Also is more code needed for DSE environment ?

Looking forward to your thoughts—thanks for your time!

@PACordonnier
Copy link
Author

PACordonnier commented Feb 20, 2025

Hi,

I was wondering if there has been any progress or if there are any updates regarding its review. I'm eager to contribute and would appreciate any feedback or suggestions you might have.

Thank you for your time and consideration!

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup Without Snapshot Creation & Deletion
1 participant