Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitalk #58

Closed
wants to merge 4 commits into from
Closed

Add gitalk #58

wants to merge 4 commits into from

Conversation

rikkix
Copy link

@rikkix rikkix commented Jan 19, 2018

add gitalk

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): N/A

What is the new behavior?

Add Gitalk

What is the new behavior?

  • Just like this:
    image

How to use?

In NexT _config.yml:

gitalk:
  enable: false  
  ClientID: # Required. Github Application Client ID.
  ClientSecret: # Required. Github Application Client Secret.
  repo: gitalk # Required. Github repository.
  owner: # Required. Github repository owner. Can be personal user or organization.
  adminUser: # Required. Github repository owner and collaborators. (Users who having write access to this repository)
  ID: location.pathname # The unique id of the page.
  labels: gitalk # Github issue labels. If you used to use Gitment, you can change it
  perPage: 15 # Pagination size, with maximum 100.
  pagerDirection: last # Comment sorting direction, available values are 'last' and 'first'.
  createIssueManually: false # If it is 'false', it is auto to make a Github issue when the administrators login.
  distractionFreeMode: false # Enable hot key (cmd|ctrl + enter) submit comment.

Does this PR introduce a breaking change?

  • Yes.
  • No.

add gitalk
@rikkix rikkix changed the title add gitalk Add gitalk Jan 19, 2018
@ivan-nginx
Copy link
Member

ivan-nginx commented Jan 19, 2018

As i say here, need to provide to user choice to use he's own server, like with gitment/gitmint.
image

@wafer-li wafer-li mentioned this pull request Jan 24, 2018
15 tasks
@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 15, 2018

Created anonym poll with votes for this feature. Please, make your vote.

owner: '{{ theme.gitalk.owner }}',
admin: ['{{ theme.gitalk.adminUser }}'],
id: {{ theme.gitalk.ID }},
labels: '{{ theme.gitalk.labels }}'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ',' at the end of line 15.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labels: ['{{ theme.gitalk.labels }}'],
Labels should be an array, or will get concat error.

@@ -58,6 +58,10 @@
{% elseif theme.valine.enable and theme.valine.appid and theme.valine.appkey %}
<div class="comments" id="comments">
</div>

{% elseif theme.gitalk.enable %}
<div id="gitalk-container"></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<div class="comments" id="comments"> <div id="gitalk-container"></div> </div>
better

@@ -58,6 +58,10 @@
{% elseif theme.valine.enable and theme.valine.appid and theme.valine.appkey %}
<div class="comments" id="comments">
</div>

{% elseif theme.gitalk.enable %}
<div id="gitalk-container"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix comments wide on mobile

  {% elseif theme.gitalk.enable %}
    <div class="comments" id="comments">
      <div id="gitalk-container"></div>
    </div>
  {% endif %}

@rikkix rikkix closed this Aug 23, 2018
@maple3142 maple3142 mentioned this pull request Nov 4, 2018
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants