-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gitalk #58
Add gitalk #58
Conversation
add gitalk
As i say here, need to provide to user choice to use he's own server, like with gitment/gitmint. |
Created anonym poll with votes for this feature. Please, make your vote. |
owner: '{{ theme.gitalk.owner }}', | ||
admin: ['{{ theme.gitalk.adminUser }}'], | ||
id: {{ theme.gitalk.ID }}, | ||
labels: '{{ theme.gitalk.labels }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ',' at the end of line 15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labels: ['{{ theme.gitalk.labels }}'],
Labels should be an array, or will get concat error.
@@ -58,6 +58,10 @@ | |||
{% elseif theme.valine.enable and theme.valine.appid and theme.valine.appkey %} | |||
<div class="comments" id="comments"> | |||
</div> | |||
|
|||
{% elseif theme.gitalk.enable %} | |||
<div id="gitalk-container"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div class="comments" id="comments"> <div id="gitalk-container"></div> </div>
better
@@ -58,6 +58,10 @@ | |||
{% elseif theme.valine.enable and theme.valine.appid and theme.valine.appkey %} | |||
<div class="comments" id="comments"> | |||
</div> | |||
|
|||
{% elseif theme.gitalk.enable %} | |||
<div id="gitalk-container"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix comments wide on mobile
{% elseif theme.gitalk.enable %}
<div class="comments" id="comments">
<div id="gitalk-container"></div>
</div>
{% endif %}
add gitalk
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number(s): N/A
What is the new behavior?
Add Gitalk
What is the new behavior?
How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?