Autogenerated Emitter is not persisted

[ls-sean-fraser]

I believe I have found another bug in the library (running the latest version). The getEmitter() method does not persist the autogenerated object. As a result, every call to that method returns a separate emitter instance, meaning that events emitted from one instance will never reach the listeners which are registered to a different instance

https://github.com/thephpleague/oauth2-server/blob/master/src/EventEmitting/EmitterAwarePolyfill.php#L16

public function getEmitter(): EventEmitter
    {
        return $this->emitter ?? new EventEmitter();
    }

Was that intended to be a ??= operator?

Workaround: explicitly call $server->setEmitter(new EventEmitter()) BEFORE assigning any grants to the server. This kind of defeats the purpose of the autogeneration.

Question: Should $server->setEmitter() automatically cascade the reassignment to any registered grant types?