Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logout endpoint #107

Merged
merged 4 commits into from
Jun 3, 2020
Merged

Add logout endpoint #107

merged 4 commits into from
Jun 3, 2020

Conversation

thomseddon
Copy link
Owner

@thomseddon thomseddon commented Apr 18, 2020

As discussed in #105

TODO:

  • implementation
  • documentation (including statelessness constraint)
  • add logout redirect config + function

@thomseddon thomseddon added this to the 2.2 milestone Apr 18, 2020
@thomseddon thomseddon self-assigned this Apr 18, 2020
@thomseddon thomseddon mentioned this pull request Apr 22, 2020
@thomseddon thomseddon added enhancement New feature or request work in progress labels Apr 30, 2020
@PrivatePuffin
Copy link

You might also want to add an option for users to add a signout forward url.
For example keycloak users could point that to the keycloak signout to end the keycloak session.

@thomseddon
Copy link
Owner Author

@Ornias1993 that makes sense - the only problem is that once the cookie is removed, the user wouldn't be able to access keycloak (if it's behind tfa) - can you set a redirect in keycloak? (If so, the user could go there first, then keycloak could send them to /_oauth/signout?

@thomseddon thomseddon changed the title Add signout endpoint Add logout endpoint Jun 1, 2020
@thomseddon
Copy link
Owner Author

I think "logout" is the better phrase for this as it more narrowly fits what this does (and you normally say OAuth2 "login", or visit the "login" page)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants