Threadsafe ENV interaction #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaclayton
force-pushed
the
threadsafe-env-interaction
branch
2 times, most recently
from
3e3710d to
cd9f132
Compare
|
|
||
| module ClimateControl | ||
| class Environment | ||
| def initialize(env = ENV) |
There was a problem hiding this comment.
Do you need this default argument? It looks like it's only used in one place.
There was a problem hiding this comment.
Nope - addressed in 0e6dfcc
joshuaclayton
force-pushed
the
threadsafe-env-interaction
branch
from
ba3731d to
8749382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6