Numpy no longer includes warnings module as attribute as of numpy v1.24.3 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaojieww
reviewed
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy no longer has the attribute
warningsand causes some of the tests to fail. This is because of the call tonumpy.warnings.catch_warnings()fromhawc_hal/healpix_handling/gnomonic_projection.py. The issue can be fixed by simply importingwarningsas most of the desired functionality comes from that module.Aside from fixing the issue mentioned above, there are some minor differences, such as the formatting of the code and removing a few unused module imports.