Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Transfer TFT By Twin ID Input validation accepts decimal value without error #3469

Closed
1 task done
0oM4R opened this issue Sep 25, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@0oM4R
Copy link
Contributor

0oM4R commented Sep 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

i tried to enter 1525.32 and it transferred to twin 1525

Test case: TC2240 : https://app.testlodge.com/a/26076/projects/40893/runs/757884/run?run_suite_id=1250709&selected=33254452

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

2.5.0

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

image

Relevant log output

.
@0oM4R 0oM4R added the type_bug Something isn't working label Sep 25, 2024
@ramezsaeed ramezsaeed added this to the 2.6.0 milestone Sep 29, 2024
@0oM4R
Copy link
Contributor Author

0oM4R commented Sep 29, 2024

add validation to the twin id field to accept integer only.

@0oM4R 0oM4R moved this to Accepted in 3.15.x Sep 29, 2024
@samaradel samaradel self-assigned this Oct 3, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.15.x Oct 3, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Oct 3, 2024
@samaradel
Copy link
Contributor

Work Completed:

Add validation on twin ID input as it should accept only integers.

@xmonader xmonader moved this from Pending Review to In Verification in 3.15.x Oct 14, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Oct 15, 2024

Verified, Devnet 038404b.

The Twin ID validation is showing an error for any incorrect twin ID.

image

TC2240 - Transfer TFT By Twin ID Input validation

@A-Harby A-Harby moved this from In Verification to Done in 3.15.x Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants