Validate twin ID input in transfer TFT page #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
| @@ -21,6 +21,7 @@ | |||
| validators.isNotEmpty('Invalid Twin ID'), | |||
| validators.isNumeric('Twin ID should be a number'), | |||
There was a problem hiding this comment.
do we need isNumeric after having isInt?
There was a problem hiding this comment.
good catch :) validator removed.
| validators.min('Twin ID should be more than 0', 1), | ||
| validators.isInt('Twin ID should be a valid integer.'), |
There was a problem hiding this comment.
please move isInt above min
There was a problem hiding this comment.
agree this will prevent this case
xmonader
reviewed
Oct 7, 2024
amiraabouhadid
approved these changes
Oct 8, 2024
AhmedHanafy725
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add validation on twin ID input as it should accept only integers.
Changes
Related Issues
Tested Scenarios
The twin ID input should accept integers only.
Checklist