Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disclaimer toolbar #2395

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Remove disclaimer toolbar #2395

merged 1 commit into from
Mar 12, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Mar 12, 2024 •
edited
Loading

Description

Remove disclaimer toolbar

image

Related Issues

Documentation PR

For UI changes, please provide the documentation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

maayarosama
maayarosama suggested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@maayarosama maayarosama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the disclaimer should say Dashboard instead of Playground rather than removing it

@amiraabouhadid
Copy link
Contributor

I think the disclaimer should say Dashboard instead of Playground rather than removing it

#2391 (comment) he asked to remove it entirely

@zaelgohary zaelgohary merged commit 333317a into development Mar 12, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_remove_disclaimer branch March 12, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@maayarosama maayarosama maayarosama approved these changes

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zaelgohary @amiraabouhadid @AhmedHanafy725 @maayarosama