Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter the undefined and empty values before making the request to filter nodes and farms. #2409

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Filter the undefined and empty values before making the request to filter nodes and farms. #2409

merged 8 commits into from
Apr 2, 2024

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented Mar 12, 2024 •
edited
Loading

Description

Filter the empty/undefined values from the object

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@amiraabouhadid
Copy link
Contributor

farm requests still have undefined fields
image

amiraabouhadid
amiraabouhadid requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid repeated code. apply filter to farms too

@Mahmoud-Emad Mahmoud-Emad changed the title Update: Filter the undefined and empty values before making the request to filter nodes and farms. Filter the undefined and empty values before making the request to filter nodes and farms. Mar 13, 2024
@Mahmoud-Emad Mahmoud-Emad changed the base branch from development_314 to development March 17, 2024 08:29
@Mahmoud-Emad Mahmoud-Emad requested a review from samaradel as a code owner March 17, 2024 08:29
zaelgohary
zaelgohary reviewed Mar 17, 2024
View reviewed changes
zaelgohary
zaelgohary approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Omda.

@Mahmoud-Emad Mahmoud-Emad marked this pull request as draft March 21, 2024 14:57
@Mahmoud-Emad Mahmoud-Emad marked this pull request as ready for review March 31, 2024 12:21
AhmedHanafy725
AhmedHanafy725 requested changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename the functions directory to unittests, and filename from query_ot_string.test.ts to query_to_string.test.ts

@Mahmoud-Emad Mahmoud-Emad merged commit 9648471 into development Apr 2, 2024
2 checks passed
@Mahmoud-Emad Mahmoud-Emad deleted the development_314_filters branch April 2, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mahmoud-Emad @amiraabouhadid @zaelgohary @AhmedHanafy725