Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance list requests in nodes and farms tables #2488

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Mar 21, 2024

Description

get the total count on_mount and on any change of filters or delete\add actions

Changes

in general, the tf filter component handle the changes on the params and it also handle on mounted and clear by calling apply
so in case of calling apply, we are passing ret_count flag to be true, the default value of the flag is false
if the flag passed, that's mean we are changing all the table data so we need to reset page to 1 and return count.

Related Issues

Documentation PR

For UI changes, Plaese provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Omar.

@0oM4R 0oM4R merged commit f52e6e1 into development Mar 26, 2024
3 checks passed
@0oM4R 0oM4R deleted the development_retcount branch March 26, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants