Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: node details behaviour #2553

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix: node details behaviour #2553

merged 1 commit into from
Apr 15, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Apr 14, 2024

Changes

  • close dialog on click outside
  • add overlay
  • fix with issue and make all cards with consistance

image

Related Issues

Documentation PR

For UI changes, Plaese provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@0oM4R
Fix: node details behaviour
dc3b479 
- close dialog on click outside
- add overlay
- fix with issue and make all cards with consistance
Mahmoud-Emad
Mahmoud-Emad approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya 3amora :)

@0oM4R 0oM4R merged commit fce1507 into development Apr 15, 2024
3 checks passed
@0oM4R 0oM4R deleted the development_nodeDetails_dialog branch April 15, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedElmdary MohamedElmdary MohamedElmdary approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@maayarosama maayarosama maayarosama approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0oM4R @MohamedElmdary @Mahmoud-Emad @maayarosama