Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workers number chip in k8s & caprover #2565

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Add workers number chip in k8s & caprover #2565

merged 2 commits into from
Apr 16, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Apr 15, 2024 •
edited
Loading

Changes

  • Add workers optional prop in tabs
  • Apply change in k8s & caprover

image

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

0oM4R
0oM4R requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we hide the chip if there is no workers added ?

@zaelgohary zaelgohary requested a review from 0oM4R April 16, 2024 10:28
@zaelgohary zaelgohary merged commit 357741e into development Apr 16, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_add_workers_chip branch April 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@0oM4R 0oM4R 0oM4R approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @AlaaElattar @0oM4R