Display the VOTE details on the DAO page #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Changes** - Added a tooltip that displays a card containing the voting details on the hover - Added the total number of proposal votes - Added the total number of 'Yes' proposal votes - Added the total number of 'No' proposal votes
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
Mahmoud-Emad
changed the title
xmonader
approved these changes
Apr 16, 2024
|
Let's change the details button to be |
maayarosama
approved these changes
Apr 16, 2024
- Renamed the 'Details' button to 'Go to proposal' - Added the 'threshold' info in the vote details to be displayed to the user
Mahmoud-Emad
force-pushed
the
development_dao_vote_details
branch
from
737490d to
da451fb
Compare
Updated
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displayed the VOTE details on the DAO page
Changes
Related Issues
Screenshots
Checklist