Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dedicated page, remove unused code from node finder #2579

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Remove dedicated page, remove unused code from node finder #2579

merged 3 commits into from
Apr 18, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Apr 18, 2024 •
edited
Loading

Description

  • Remove dedicated page
  • Remove dedicated route
  • Remove unused code from node finder
  • Fix import in node finder

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

0oM4R
0oM4R approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure to update the info grid section also, and attach the issue or draft pr here

@0oM4R
Copy link
Contributor

0oM4R commented Apr 18, 2024

also we may keep the old rout and make it refer to the node finder page to avoid 404 page later

@Mahmoud-Emad
Copy link
Contributor

Mahmoud-Emad commented Apr 18, 2024 •
edited
Loading

also we may keep the old rout and make it refer to the node finder page to avoid 404 page later

I prefer this situation, @zaelgohary please keep the route of the dedicated nodes page as it may be used somewhere else, but redirect the request to the node finder

@zaelgohary
Copy link
Contributor Author

@0oM4R applied comments. Also, opened an issue for the manual to be updated here

@zaelgohary zaelgohary requested a review from 0oM4R April 18, 2024 12:07
samaradel
samaradel approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@samaradel samaradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

0oM4R
0oM4R approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks ya Zainab

@zaelgohary zaelgohary merged commit 1272141 into development Apr 18, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_remove_dedicated_page branch April 18, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaradel samaradel samaradel approved these changes

@0oM4R 0oM4R 0oM4R approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zaelgohary @0oM4R @Mahmoud-Emad @samaradel