-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlock grace period contracts #2582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that we let the user unlock the contract manually. What if we unlock contract/contracts automatically if the user has enough balance? This would save us any new changes in the UI.
this method returns a object of contracts and its ids with the lock details
…-ts into development_unlockContracts
…-ts into development_unlockContracts
What are your thoughts on using the term 'unlock'? Would using something like 'resume' or 'restore' be more friendly since the related workload is paused? |
resume sounds more intuitive |
…-sdk-ts into development_unlockContracts
Can we add a note that in some cases the actual deducted amount when contracts are resumed could be less than estimated here? |
I prefer to not add it as it's not harmful. Cause sometimes when we add many notes, the user becomes too lazy to read them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update
Description
add button to manually unlock grace period contract, instead of waiting for the next billing cycle

Changes
billContractForBlock
Add an unlock button to the Contract lock details dailog
if the contract is on rented node, there is no unlock button, user should unlock the rent contract and the alert is shown
selected contracts from the table could be unlocked by unlock button in each table
note
we can't guarantee that the contracts will be moved to the created state, as the chain method
billContractForBlock
do not return an error if the balance is not enough, but it only updates the locked amount,Also, we are updating the contracts table after 30 seconds from calling the method
Related Issues
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist