Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default VProgressCircular color #2664

Merged
merged 4 commits into from
May 9, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented May 8, 2024

Description

  • Override button VProgressCircular color.
  • Fix vm deleting spinner color.

Changes

-Add color primary to components loader.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary
Copy link
Member

MohamedElmdary commented May 8, 2024

@samaradel
can't we just override VBtn -> VProgressCircular

const vuetify = createVuetify({
  defaults: {
    VAlert: {
      variant: "tonal",
    },
    VProgressCircular: {
      size: 50,
      width: 7,
      color: "primary",
    },
    VBtn: {
      VProgressCircular: {
        color: undefined,
      },
    },
  },
  // ...
  })

will result in returning them to inherit from button (it's parent)
image

@Mahmoud-Emad
Copy link
Contributor

The color is still different here

image

@samaradel samaradel marked this pull request as draft May 9, 2024 08:17
@samaradel samaradel marked this pull request as ready for review May 9, 2024 09:14
@samaradel
Copy link
Contributor Author

@Mahmoud-Emad fixed
image

Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i delete a vm contract i do not get a spinner on the delete button in the dialog,
however, i get red spinners in the table
image

@MohamedElmdary
Copy link
Member

@amiraabouhadid that's because we don't have loading on button

image

@amiraabouhadid amiraabouhadid merged commit 611878e into development May 9, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_vProgressCircular branch May 9, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants