Sort nodes by free cru #2692
Merged
Sort nodes by free cru #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R and
mohamedamer453
as code owners
| sortBy: SortBy.Status, | ||
| sortOrder: SortOrder.Asc, | ||
| sortBy: SortBy.FreeCRU, | ||
| sortOrder: SortOrder.Desc, |
There was a problem hiding this comment.
It was Asc why we changed it to Desc
There was a problem hiding this comment.
Asc takes the nodes with small free cores in the first etc node with ID 11 which we don't need.
Mahmoud-Emad
approved these changes
May 13, 2024
AlaaElattar
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sort nodes in Node Finder by free CRU
Changes
before
Screencast.from.13-05-24.13.53.41.webm
after
Screencast.from.13-05-24.13.17.16.webm
Related Issues
Checklist