Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle contracts pagination #2717

Merged
merged 5 commits into from
May 19, 2024

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented May 19, 2024

Description

  • The contract list can't load a large amount of contracts.

Changes

  • Handled pagination in contracts page.

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Screencast.from.05-19-2024.12.12.23.PM.webm

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@AlaaElattar AlaaElattar marked this pull request as ready for review May 19, 2024 09:18
@amiraabouhadid amiraabouhadid merged commit d392720 into development May 19, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_contracts_pagination branch May 19, 2024 11:47
Comment on lines -8 to +7
:deleting="deleting"
loading-text="Loading nodes..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading contracts?

<template #[`item.actions`]="{ item }">
<v-tooltip :text="failedContractId == item.contractId ? 'Retry' : 'Show Details'">
<v-tooltip :text="failedContractId == item.contract_id ? 'Retry' : 'Show Details'">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contractId

@Mahmoud-Emad
Copy link
Contributor

Instead of using a reference for loading and counting maybe we can create an object that holds all of these fields inside

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants