Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: reload gateway nodes button #2972

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix: reload gateway nodes button #2972

merged 2 commits into from
Jun 13, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Jun 12, 2024

  • add reload node logic, and reset the gateway field, separate from loadDomains logic that actually load more domains

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@0oM4R
Fix: reload gateway nodes
b5fde6b 
- add reload node logic, and reset the gateway field
Mahmoud-Emad
Mahmoud-Emad reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Omar

@Mahmoud-Emad
Copy link
Contributor

While testing, I noticed that 2 requests are invoked when the reload icon is pressed. Both of them have the same response/result. Are they both needed?

Screencast.from.06-13-2024.08.46.01.AM.webm

@0oM4R 0oM4R marked this pull request as draft June 13, 2024 09:22
@0oM4R
Copy link
Contributor Author

0oM4R commented Jun 13, 2024

While testing, I noticed that 2 requests are invoked when the reload icon is pressed. Both of them have the same response/result. Are they both needed?

Screencast.from.06-13-2024.08.46.01.AM.webm

@Mahmoud-Emad
they are not the same; first is to get the page count, with return count flag, and the other is to get the gateway names.
Anyway, I think this is not related to the issue If you have any idea about enhancing the flow, please open a separate issue with it

@0oM4R 0oM4R requested a review from Mahmoud-Emad June 13, 2024 09:43
@0oM4R 0oM4R marked this pull request as ready for review June 13, 2024 09:43
@Mahmoud-Emad
Copy link
Contributor

#2982

@0oM4R 0oM4R merged commit 23bbe27 into development Jun 13, 2024
3 checks passed
@0oM4R 0oM4R deleted the development_fix_reloadGatewayNodes branch June 13, 2024 10:42
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaradel samaradel samaradel approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@0oM4R @Mahmoud-Emad @samaradel @xmonader