Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node statistics UI #2989

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Node statistics UI #2989

merged 2 commits into from
Jun 25, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Jun 13, 2024 •
edited
Loading

Description

  • Center all items vertically
  • Remove vertical divider
  • Let the last card take the full-width
  • Make all cards height equal on small screens
  • Adjust the statistics page grid

Changes

image

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
- Center all items vertically
a2fded9 
- Remove vertical divider
amiraabouhadid
amiraabouhadid requested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix spacing between cards
image

@Mahmoud-Emad Mahmoud-Emad self-requested a review June 23, 2024 06:05
zaelgohary
zaelgohary requested changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue requested the last card to take up the whole space if it's the only card in the row.

@samaradel samaradel marked this pull request as draft June 23, 2024 07:53
@samaradel
- Let last card takes the full width
edfc0eb 
- Make all cards height equal in small screens
- Adjust statistics page grid
@samaradel samaradel marked this pull request as ready for review June 23, 2024 08:34
@samaradel samaradel merged commit c4c73fb into development_2.6 Jun 25, 2024
4 checks passed
@samaradel samaradel deleted the development_2.6_node_statistics branch June 25, 2024 07:12
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary zaelgohary approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@maayarosama maayarosama maayarosama approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar

@0oM4R 0oM4R Awaiting requested review from 0oM4R

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@samaradel @zaelgohary @amiraabouhadid @Mahmoud-Emad @maayarosama @xmonader